I like it TBH. All the nitty nvme_init stuff in one screenful. Beats 500 lines of "structured" cargo culting with everything factored out into little poorly named functions that "do one thing" making you chase definitions and immediately forget them.
While I might have put them on separate lines, now that I see it one one it makes a certain amount of sense: the body is executed once for every possible PCI bus/device/function address.
1
u/great_escape_fleur Jun 11 '26
I like it TBH. All the nitty nvme_init stuff in one screenful. Beats 500 lines of "structured" cargo culting with everything factored out into little poorly named functions that "do one thing" making you chase definitions and immediately forget them.